On 9/5/22 13:00, Javier Martinez Canillas wrote: >>> +static void ssd130x_encoder_helper_atomic_enable(struct drm_encoder *encoder, >>> + struct drm_atomic_state *state) >>> +{ >>> + struct drm_device *drm = encoder->dev; >>> + struct ssd130x_device *ssd130x = drm_to_ssd130x(drm); >>> + int ret; >>> + >>> + ret = ssd130x_power_on(ssd130x); >>> + if (ret) >>> return; >>> >>> - ssd130x_fb_blit_rect(plane_state->fb, &shadow_plane_state->data[0], &dst_clip); >>> + ret = ssd130x_init(ssd130x); >>> + if (ret) >>> + return ssd130x_power_off(ssd130x); >> >> It returns a value from a function returning 'void'? >> > > Right. I'll fix it in v2 as well. > Actually, this return statement is correct since ssd130x_power_off() return value is 'void' as well. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat