On Tue, 2022-08-30 at 12:13 +0300, Krzysztof Kozlowski wrote:
> >
> On 30/08/2022 09:39, zheng-yan.chen wrote:
> > Modify gamma compatible for mt8195.
>
> Commit should explain why. "What" we all can easily see.
> > Fixes: 16590e634f1d ("arm64: dts: mt8195: Add display node for
> > vdosys0")
>
Hello Krzysztof,
Thanks for the review,
I will edit commit message below:
Modify gamma compatible for mt8195.
This modification is because of that
mt8183 gamma driver data is not compatible with mt8195 gamma.
Thus, need to delete mt8183 gamma compatible from mt8195 gamma.
> Your patchset is not bisectable and might cause ABI break. I doubt
> that
> it matches the criteria of backports, especially that you did not
> describe here bug being fixed.
>
> Drop the tag and explain reasons for ABI break.
>
I will drop the tag and add based-on messages below.
Base on [1]:
[1] arm64: dts: mt8195: Add display node for vdosys0
-
https://patchwork.kernel.org/project/linux-mediatek/patch/20220811025813.21492-21-tinghan.shen@xxxxxxxxxxxx/
Best Regards,
Zheng-Yan Chen.
> > Signed-off-by: zheng-yan.chen <zheng-yan.chen@xxxxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > index a50ebb5d145f..d4110f6fac62 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > @@ -2022,7 +2022,7 @@
> > };
> >
> > gamma0: gamma@1c006000 {
> > - compatible = "mediatek,mt8195-disp-gamma",
> > "mediatek,mt8183-disp-gamma";
> > + compatible = "mediatek,mt8195-disp-gamma";
> > reg = <0 0x1c006000 0 0x1000>;
> > interrupts = <GIC_SPI 642 IRQ_TYPE_LEVEL_HIGH
> > 0>;
> > power-domains = <&spm
> > MT8195_POWER_DOMAIN_VDOSYS0>;
>
>
> Best regards,
> Krzysztof
