Hey Chris,
Sorry about being slow getting to this.
On Wed, 30 Mar 2022 at 21:39, Chris Morgan <macroalpha82@xxxxxxxxx> wrote:
>
> From: Chris Morgan <macromorgan@xxxxxxxxxxx>
>
> Update dt-binding documentation to add support for setting byteswap of
> chrontel ch7033.
>
> New property name of chrontel,byteswap added to set the byteswap order.
> This property is optional.
>
> Signed-off-by: Chris Morgan <macromorgan@xxxxxxxxxxx>
> ---
> .../bindings/display/bridge/chrontel,ch7033.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/chrontel,ch7033.yaml b/Documentation/devicetree/bindings/display/bridge/chrontel,ch7033.yaml
> index bb6289c7d375..ecd3062c5215 100644
> --- a/Documentation/devicetree/bindings/display/bridge/chrontel,ch7033.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/chrontel,ch7033.yaml
> @@ -14,6 +14,14 @@ properties:
> compatible:
> const: chrontel,ch7033
>
> + chrontel,byteswap:
> + $ref: /schemas/types.yaml#/definitions/uint8
> + enum: [0, 1, 2, 3, 4, 5]
> + description: |
> + Set the byteswap value of the bridge. Values 0-5 correspond to
> + BYTE_SWAP_RGB, BYTE_SWAP_RBG, BYTE_SWAP_GRB, BYTE_SWAP_GBR,
> + BYTE_SWAP_BRG, and BYTE_SWAP_BGR respectively.
This is acceptable, but maybe we can make this a little bit nicer by
documenting the enum and it's description on the same line.
enum:
- 0 # automode
- 1 # internal
- 2 # external
> +
> reg:
> maxItems: 1
> description: I2C address of the device
> --
> 2.25.1
>
With this addressed, please add my r-b.
Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx>
