On Wed, 10 Aug 2022 at 11:27, Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
>
> On 01/08/2022 14:54, Marek Vasut wrote:
> > The drm_of_lvds_get_data_mapping() returns either negative value on
> > error or MEDIA_BUS_FMT_* otherwise. The check for 'ret' would also
> > catch the positive case of MEDIA_BUS_FMT_* and lead to probe failure
> > every time 'data-mapping' DT property is specified.
> >
> > Fixes: 7c4dd0a266527 ("drm: of: Add drm_of_lvds_get_data_mapping")
> > Signed-off-by: Marek Vasut <marex@xxxxxxx>
> > Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> > To: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > ---
> > drivers/gpu/drm/bridge/lvds-codec.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/lvds-codec.c b/drivers/gpu/drm/bridge/lvds-codec.c
> > index 702ea803a743c..39e7004de7200 100644
> > --- a/drivers/gpu/drm/bridge/lvds-codec.c
> > +++ b/drivers/gpu/drm/bridge/lvds-codec.c
> > @@ -180,7 +180,7 @@ static int lvds_codec_probe(struct platform_device *pdev)
> > of_node_put(bus_node);
> > if (ret == -ENODEV) {
> > dev_warn(dev, "missing 'data-mapping' DT property\n");
> > - } else if (ret) {
> > + } else if (ret < 0) {
> > dev_err(dev, "invalid 'data-mapping' DT property\n");
> > return ret;
> > } else {
>
> Reviewed-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
Applied to drm-misc-next.
