Re: [PATCH] tty/vt: Remove printable variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 26. 08. 22, 22:24, Daniel Vetter wrote:
Every since the 0.99.7A release when console_register() was introduced
it's become impossible to call vt_console_print (called
console_print() back then still) directly. Which means the
initialization issue this variable protected against is no more.

Give it a send off with style and let it rest in peace.

FWIW:
Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>

In hopes, nothing breaks.

Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Cc: Jiri Slaby <jirislaby@xxxxxxxxxx>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@xxxxxxxxxxxxxxx>
Cc: nick black <dankamongmen@xxxxxxxxx>
Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
Cc: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
Cc: Yangxi Xiang <xyangxi5@xxxxxxxxx>
Cc: Xuezhi Zhang <zhangxuezhi1@xxxxxxxxxxx>
---
  drivers/tty/vt/vt.c | 4 ----
  1 file changed, 4 deletions(-)

diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index ae9c926acd6f..4d29e4a17db7 100644
--- a/drivers/tty/vt/vt.c
+++ b/drivers/tty/vt/vt.c
@@ -157,7 +157,6 @@ static void set_palette(struct vc_data *vc);
#define vt_get_kmsg_redirect() vt_kmsg_redirect(-1) -static int printable; /* Is console ready for printing? */
  int default_utf8 = true;
  module_param(default_utf8, int, S_IRUGO | S_IWUSR);
  int global_cursor_default = -1;
@@ -3085,8 +3084,6 @@ static void vt_console_print(struct console *co, const char *b, unsigned count)
  	int kmsg_console;
/* console busy or not yet initialized */
-	if (!printable)
-		return;
  	if (!spin_trylock(&printing_lock))
  		return;
@@ -3537,7 +3534,6 @@ static int __init con_init(void)
  	pr_info("Console: %s %s %dx%d\n",
  		vc->vc_can_do_color ? "colour" : "mono",
  		display_desc, vc->vc_cols, vc->vc_rows);
-	printable = 1;
console_unlock();

thanks,
--
js
suse labs




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux