On Tue, 2022-08-23 at 11:38 +0300, Krzysztof Kozlowski wrote:
> On 22/08/2022 12:19, zheng-yan.chen wrote:
> > mt8195 uses 10bit-to-12bit gamma-LUT, which is different from
> > current 9bit-to-10bit gamma-LUT, so this patch add its own
> > compatible
> > for mt8195.
>
> I am not sure if this explains the need for change. Is mt8195 still
> compatible with mt8183 or not? Your driver change suggests that it is
> and points that this commit is wrong.
>
> >
> > Signed-off-by: zheng-yan.chen <zheng-yan.chen@xxxxxxxxxxxx>
> >
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml | 3
> > ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
> > .yaml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
> > .yaml
> > index a89ea0ea7542..fbd7b9664a78 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
> > .yaml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
> > .yaml
> > @@ -25,11 +25,12 @@ properties:
> > - const: mediatek,mt8173-disp-gamma
> > - items:
> > - const: mediatek,mt8183-disp-gamma
> > + - items:
> > + - const: mediatek,mt8195-disp-gamma
> > - items:
> > - enum:
> > - mediatek,mt8186-disp-gamma
> > - mediatek,mt8192-disp-gamma
> > - - mediatek,mt8195-disp-gamma
>
>
> Best regards,
> Krzysztof
mt8195 is not compatible with mt8183 now, I will change commit message
to:
mt8195 uses 10bit-to-12bit gamma-LUT, which is not compatible with
current 9bit-to-10bit gamma-LUT.
This patch thus add constant compatible for mt8195, which means
that mt8195 should only use specified mt8195 gamma driver data.
Also, delete related compatible from enum, to ensure that
mt8195 will not accidentally get others' gamma driver data and thus
cause fatal error.
Best regards,
Zheng-Yan Chen
