On Mon, 2022-08-22 at 09:23 -0400, Nícolas F. R. A. Prado wrote: > On Mon, Aug 22, 2022 at 08:50:45PM +0800, xinlei.lee wrote: > [..] > > Hi Nícolas: > > > > Thanks for your careful review. > > I will correct it in the next version: > > 1. Modify key nouns in the description; > > 2. Modify the label of jitao to Co-developed-by; > > To be clear, you shouldn't change jitao's signed-off-by to a co- > developed-by, > but add a co-developed-by. If you check the link I sent earlier [1], > it should > be clear that you should have something like > > Co-developed-by: Jitao Shi <jitao.shi@xxxxxxxxxxxx> > Signed-off-by: Jitao Shi <jitao.shi@xxxxxxxxxxxx> > Signed-off-by: Xinlei Lee <xinlei.lee@xxxxxxxxxxxx> > > [1] > https://urldefense.com/v3/__https://www.kernel.org/doc/html/latest/process/submitting-patches.html*when-to-use-acked-by-cc-and-co-developed-by__;Iw!!CTRNKA9wMg0ARbw!1bj8UrTx32ihWiD-1dbKF8XsXg4tod3zHr90aemam8bnL_4jgcA9oa44UiF9ILFN9A$ > > > Thanks, > Nícolas > > > 3. Macro definition address lowercase problem and function naming. > > > > If there are no other questions, I will send out the second edition > > in > > the near future. > > > > Best Regards! > > xinlei > > Hi Nícolas: Yes, maybe my statement is not very accurate, thank you for your explanation. Best Regards! Xinlei
