Re: [PATCH v5 3/4] drm/lcdif: Clean up debug prints and comments

[Marek Vasut <marex@xxxxxxx>]

On 8/22/22 08:24, Alexander Stein wrote:

Hi,

[...]

> > --- a/drivers/gpu/drm/mxsfb/lcdif_kms.c
> > +++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c
> > @@ -203,7 +203,7 @@ static void lcdif_crtc_mode_set_nofb(struct
> > lcdif_drm_private *lcdif, DRM_DEV_DEBUG_DRIVER(drm->dev, "Pixel clock:
> > %dkHz (actual: %dkHz)\n", m->crtc_clock,
> >   			     (int)(clk_get_rate(lcdif->clk) / 1000));
> > -	DRM_DEV_DEBUG_DRIVER(drm->dev, "Connector bus_flags: 0x%08X\n",
> > +	DRM_DEV_DEBUG_DRIVER(drm->dev, "Bridge bus_flags: 0x%08X\n",
> >   			     bus_flags);
> >   	DRM_DEV_DEBUG_DRIVER(drm->dev, "Mode flags: 0x%08X\n", m->flags);
>
> Is there any benefit to explicitly state it is the bridge input flags?

I don't think so, since it cannot be any other flags (you cannot link 
bridge output to crtc output for example).

[...]