Hi Xinlei, On Fri, Aug 05, 2022 at 05:57:41PM +0800, xinlei.lee@xxxxxxxxxxxx wrote: > From: Xinlei Lee <xinlei.lee@xxxxxxxxxxxx> > > Dpi output needs to adjust the output format to dual edge for MT8186. Could you explain a bit more why this is needed? What does this configuration do? And why is MMSYS involved in a DPI configuration? Also, is this a configuration specific to MT8186? I enabled the flag on MT8192 just to test and didn't see any difference in behavior. > > Signed-off-by: Jitao Shi <jitao.shi@xxxxxxxxxxxx> If Jitao also helped in the writing of this code, then there should also be a co-developed-by tag for Jitao before the Signed-off-by [1]. [1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by > Signed-off-by: Xinlei Lee <xinlei.lee@xxxxxxxxxxxx> [..] > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c [..] > @@ -151,6 +154,7 @@ struct mtk_dpi_conf { > u32 yuv422_en_bit; > u32 csc_enable_bit; > u32 pixels_per_iter; > + bool rgb888_dual_enable; You're missing a description of this property in the struct's comment above: drivers/gpu/drm/mediatek/mtk_dpi.c:160: warning: Function parameter or member 'rgb888_dual_enable' not described in 'mtk_dpi_conf' Thanks, Nícolas
