Hi, Thanks for testing. This series need to based on another mmsys series [1]. All the implicit-function-declaration functions are newly added in [2]. [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=669098 [2] https://patchwork.kernel.org/project/linux-mediatek/patch/20220819061011.7672-6-nancy.lin@xxxxxxxxxxxx/ Thanks, Nancy On Fri, 2022-08-19 at 18:14 +0800, kernel test robot wrote: > Hi "Nancy.Lin", > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on drm-misc/drm-misc-next] > [cannot apply to robh/for-next mbgg-mediatek/for-next] > [If your patch is applied to the wrong git tree, kindly drop us a > note. > And when submitting patch, we suggest to use '--base' as documented > in > https://urldefense.com/v3/__https://git-scm.com/docs/git-format-patch*_base_tree_information__;Iw!!CTRNKA9wMg0ARbw!wNjl5G7qt3vY_FW8w5Hhk8DfDRqU7QQLd0xm_MUAT7uF23DX0MvmaNio_hpgE9hK$ > ] > > url: > https://urldefense.com/v3/__https://github.com/intel-lab-lkp/linux/commits/Nancy-Lin/Add-MediaTek-SoC-DRM-vdosys1-support-for-mt8195/20220819-142314__;!!CTRNKA9wMg0ARbw!wNjl5G7qt3vY_FW8w5Hhk8DfDRqU7QQLd0xm_MUAT7uF23DX0MvmaNio_i9pzMeG$ > > base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next > config: arm-allyesconfig ( > https://urldefense.com/v3/__https://download.01.org/0day-ci/archive/20220819/202208191837.iIwHfovs-lkp@xxxxxxxxx/config__;!!CTRNKA9wMg0ARbw!wNjl5G7qt3vY_FW8w5Hhk8DfDRqU7QQLd0xm_MUAT7uF23DX0MvmaNio_vxbrlxE$ > ) > compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget > https://urldefense.com/v3/__https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross__;!!CTRNKA9wMg0ARbw!wNjl5G7qt3vY_FW8w5Hhk8DfDRqU7QQLd0xm_MUAT7uF23DX0MvmaNio_kKzkkvN$ > -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # > https://urldefense.com/v3/__https://github.com/intel-lab-lkp/linux/commit/ec3724f819412feab6e61118e61e574a86aa4dc0__;!!CTRNKA9wMg0ARbw!wNjl5G7qt3vY_FW8w5Hhk8DfDRqU7QQLd0xm_MUAT7uF23DX0MvmaNio_sBdpge9$ > > git remote add linux-review > https://urldefense.com/v3/__https://github.com/intel-lab-lkp/linux__;!!CTRNKA9wMg0ARbw!wNjl5G7qt3vY_FW8w5Hhk8DfDRqU7QQLd0xm_MUAT7uF23DX0MvmaNio_iv3Tqqs$ > > git fetch --no-tags linux-review Nancy-Lin/Add-MediaTek-SoC- > DRM-vdosys1-support-for-mt8195/20220819-142314 > git checkout ec3724f819412feab6e61118e61e574a86aa4dc0 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 > make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All errors (new ones prefixed by >>): > > drivers/gpu/drm/mediatek/mtk_ethdr.c: In function > 'mtk_ethdr_layer_config': > > > drivers/gpu/drm/mediatek/mtk_ethdr.c:171:9: error: implicit > > > declaration of function 'mtk_mmsys_mixer_in_config' [- > > > Werror=implicit-function-declaration] > > 171 | mtk_mmsys_mixer_in_config(priv->mmsys_dev, idx + > 1, alpha_con ? false : true, > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/mediatek/mtk_ethdr.c: In function > 'mtk_ethdr_config': > > > drivers/gpu/drm/mediatek/mtk_ethdr.c:232:9: error: implicit > > > declaration of function 'mtk_mmsys_hdr_confing'; did you mean > > > 'mtk_mmsys_ddp_connect'? [-Werror=implicit-function-declaration] > > 232 | mtk_mmsys_hdr_confing(priv->mmsys_dev, w / 2, h, > cmdq_pkt); > | ^~~~~~~~~~~~~~~~~~~~~ > | mtk_mmsys_ddp_connect > > > drivers/gpu/drm/mediatek/mtk_ethdr.c:233:9: error: implicit > > > declaration of function 'mtk_mmsys_mixer_in_channel_swap' [- > > > Werror=implicit-function-declaration] > > 233 | mtk_mmsys_mixer_in_channel_swap(priv->mmsys_dev, > 4, 0, cmdq_pkt); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > > > vim +/mtk_mmsys_mixer_in_config +171 > drivers/gpu/drm/mediatek/mtk_ethdr.c > > 146 > 147 void mtk_ethdr_layer_config(struct device *dev, > unsigned int idx, > 148 struct mtk_plane_state > *state, > 149 struct cmdq_pkt *cmdq_pkt) > 150 { > 151 struct mtk_ethdr *priv = dev_get_drvdata(dev); > 152 struct mtk_ethdr_comp *mixer = &priv- > >ethdr_comp[ETHDR_MIXER]; > 153 struct mtk_plane_pending_state *pending = > &state->pending; > 154 unsigned int offset = (pending->x & 1) << 31 | > pending->y << 16 | pending->x; > 155 unsigned int align_width = ALIGN_DOWN(pending- > >width, 2); > 156 unsigned int alpha_con = 0; > 157 > 158 dev_dbg(dev, "%s+ idx:%d", __func__, idx); > 159 > 160 if (idx >= 4) > 161 return; > 162 > 163 if (!pending->enable) { > 164 mtk_ddp_write(cmdq_pkt, 0, &mixer- > >cmdq_base, mixer->regs, MIX_L_SRC_SIZE(idx)); > 165 return; > 166 } > 167 > 168 if (state->base.fb && state->base.fb->format- > >has_alpha) > 169 alpha_con = MIXER_ALPHA_AEN | > MIXER_ALPHA; > 170 > > 171 mtk_mmsys_mixer_in_config(priv->mmsys_dev, idx > + 1, alpha_con ? false : true, > 172 DEFAULT_9BIT_ALPHA, > 173 pending->x & 1 ? > MIXER_INX_MODE_EVEN_EXTEND : > 174 MIXER_INX_MODE_BYPASS > , align_width / 2 - 1, cmdq_pkt); > 175 > 176 mtk_ddp_write(cmdq_pkt, pending->height << 16 | > align_width, &mixer->cmdq_base, > 177 mixer->regs, > MIX_L_SRC_SIZE(idx)); > 178 mtk_ddp_write(cmdq_pkt, offset, &mixer- > >cmdq_base, mixer->regs, MIX_L_SRC_OFFSET(idx)); > 179 mtk_ddp_write_mask(cmdq_pkt, alpha_con, &mixer- > >cmdq_base, mixer->regs, MIX_L_SRC_CON(idx), > 180 0x1ff); > 181 mtk_ddp_write_mask(cmdq_pkt, BIT(idx), &mixer- > >cmdq_base, mixer->regs, MIX_SRC_CON, > 182 BIT(idx)); > 183 } > 184 > 185 void mtk_ethdr_config(struct device *dev, unsigned int > w, > 186 unsigned int h, unsigned int > vrefresh, > 187 unsigned int bpc, struct cmdq_pkt > *cmdq_pkt) > 188 { > 189 struct mtk_ethdr *priv = dev_get_drvdata(dev); > 190 struct mtk_ethdr_comp *vdo_fe0 = &priv- > >ethdr_comp[ETHDR_VDO_FE0]; > 191 struct mtk_ethdr_comp *vdo_fe1 = &priv- > >ethdr_comp[ETHDR_VDO_FE1]; > 192 struct mtk_ethdr_comp *gfx_fe0 = &priv- > >ethdr_comp[ETHDR_GFX_FE0]; > 193 struct mtk_ethdr_comp *gfx_fe1 = &priv- > >ethdr_comp[ETHDR_GFX_FE1]; > 194 struct mtk_ethdr_comp *vdo_be = &priv- > >ethdr_comp[ETHDR_VDO_BE]; > 195 struct mtk_ethdr_comp *mixer = &priv- > >ethdr_comp[ETHDR_MIXER]; > 196 > 197 dev_dbg(dev, "%s-w:%d, h:%d\n", __func__, w, > h); > 198 > 199 mtk_ddp_write(cmdq_pkt, > HDR_VDO_FE_0804_BYPASS_ALL, &vdo_fe0->cmdq_base, > 200 vdo_fe0->regs, > HDR_VDO_FE_0804_HDR_DM_FE); > 201 > 202 mtk_ddp_write(cmdq_pkt, > HDR_VDO_FE_0804_BYPASS_ALL, &vdo_fe1->cmdq_base, > 203 vdo_fe1->regs, > HDR_VDO_FE_0804_HDR_DM_FE); > 204 > 205 mtk_ddp_write(cmdq_pkt, > HDR_GFX_FE_0204_BYPASS_ALL, &gfx_fe0->cmdq_base, > 206 gfx_fe0->regs, > HDR_GFX_FE_0204_GFX_HDR_FE); > 207 > 208 mtk_ddp_write(cmdq_pkt, > HDR_GFX_FE_0204_BYPASS_ALL, &gfx_fe1->cmdq_base, > 209 gfx_fe1->regs, > HDR_GFX_FE_0204_GFX_HDR_FE); > 210 > 211 mtk_ddp_write(cmdq_pkt, > HDR_VDO_BE_0204_BYPASS_ALL, &vdo_be->cmdq_base, > 212 vdo_be->regs, > HDR_VDO_BE_0204_VDO_DM_BE); > 213 > 214 mtk_ddp_write(cmdq_pkt, MIX_FUNC_DCM_ENABLE, > &mixer->cmdq_base, mixer->regs, MIX_FUNC_DCM0); > 215 mtk_ddp_write(cmdq_pkt, MIX_FUNC_DCM_ENABLE, > &mixer->cmdq_base, mixer->regs, MIX_FUNC_DCM1); > 216 mtk_ddp_write(cmdq_pkt, h << 16 | w, &mixer- > >cmdq_base, mixer->regs, MIX_ROI_SIZE); > 217 mtk_ddp_write(cmdq_pkt, BGCLR_BLACK, &mixer- > >cmdq_base, mixer->regs, MIX_ROI_BGCLR); > 218 mtk_ddp_write(cmdq_pkt, NON_PREMULTI_SOURCE, > &mixer->cmdq_base, mixer->regs, > 219 MIX_L_SRC_CON(0)); > 220 mtk_ddp_write(cmdq_pkt, NON_PREMULTI_SOURCE, > &mixer->cmdq_base, mixer->regs, > 221 MIX_L_SRC_CON(1)); > 222 mtk_ddp_write(cmdq_pkt, NON_PREMULTI_SOURCE, > &mixer->cmdq_base, mixer->regs, > 223 MIX_L_SRC_CON(2)); > 224 mtk_ddp_write(cmdq_pkt, NON_PREMULTI_SOURCE, > &mixer->cmdq_base, mixer->regs, > 225 MIX_L_SRC_CON(3)); > 226 mtk_ddp_write(cmdq_pkt, 0x0, &mixer->cmdq_base, > mixer->regs, MIX_L_SRC_SIZE(0)); > 227 mtk_ddp_write(cmdq_pkt, OUTPUT_NO_RND | > SOURCE_RGB_SEL | BACKGROUND_RELAY, > 228 &mixer->cmdq_base, mixer->regs, > MIX_DATAPATH_CON); > 229 mtk_ddp_write_mask(cmdq_pkt, MIX_SRC_L0_EN, > &mixer->cmdq_base, mixer->regs, > 230 MIX_SRC_CON, MIX_SRC_L0_EN); > 231 > > 232 mtk_mmsys_hdr_confing(priv->mmsys_dev, w / 2, > h, cmdq_pkt); > > 233 mtk_mmsys_mixer_in_channel_swap(priv- > >mmsys_dev, 4, 0, cmdq_pkt); > 234 } > 235 >
