Hi Laurent, > 2022/08/19 11:01、Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>のメール: > > Hi Hayama-san, > > Thank you for the patch. > > On Wed, Aug 10, 2022 at 05:37:09PM +0900, Takanari Hayama wrote: >> To support DRM blend mode in R-Car DU driver, we must be able to pass >> a plane with the premultiplied alpha. Adding a new property to >> vsp1_du_atomic_config allows the R-Car DU driver to pass the >> premultiplied alpha plane. >> >> Signed-off-by: Takanari Hayama <taki@xxxxxxxxxx> >> --- >> drivers/media/platform/renesas/vsp1/vsp1_drm.c | 2 ++ >> include/media/vsp1.h | 2 ++ >> 2 files changed, 4 insertions(+) >> >> diff --git a/drivers/media/platform/renesas/vsp1/vsp1_drm.c b/drivers/media/platform/renesas/vsp1/vsp1_drm.c >> index 0c2507dc03d6..019e18976bd8 100644 >> --- a/drivers/media/platform/renesas/vsp1/vsp1_drm.c >> +++ b/drivers/media/platform/renesas/vsp1/vsp1_drm.c >> @@ -856,6 +856,8 @@ int vsp1_du_atomic_update(struct device *dev, unsigned int pipe_index, >> rpf->mem.addr[1] = cfg->mem[1]; >> rpf->mem.addr[2] = cfg->mem[2]; >> >> + rpf->format.flags = (cfg->premult) ? V4L2_PIX_FMT_FLAG_PREMUL_ALPHA : 0; > > I'll drop the parentheses when applying. Thank you! > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > >> + >> vsp1->drm->inputs[rpf_index].crop = cfg->src; >> vsp1->drm->inputs[rpf_index].compose = cfg->dst; >> vsp1->drm->inputs[rpf_index].zpos = cfg->zpos; >> diff --git a/include/media/vsp1.h b/include/media/vsp1.h >> index cc1b0d42ce95..48f4a5023d81 100644 >> --- a/include/media/vsp1.h >> +++ b/include/media/vsp1.h >> @@ -51,6 +51,7 @@ int vsp1_du_setup_lif(struct device *dev, unsigned int pipe_index, >> * @dst: destination rectangle on the display (integer coordinates) >> * @alpha: alpha value (0: fully transparent, 255: fully opaque) >> * @zpos: Z position of the plane (from 0 to number of planes minus 1) >> + * @premult: true for premultiplied alpha >> */ >> struct vsp1_du_atomic_config { >> u32 pixelformat; >> @@ -60,6 +61,7 @@ struct vsp1_du_atomic_config { >> struct v4l2_rect dst; >> unsigned int alpha; >> unsigned int zpos; >> + bool premult; >> }; >> >> /** > > -- > Regards, > > Laurent Pinchart Cheers, Takanari Hayama, Ph.D. <taki@xxxxxxxxxx> IGEL Co., Ltd. https://www.igel.co.jp/