Re: [PATCH linux-next] drm/amdgpu/vcn: Remove unused assignment in vcn_v4_0_stop

Khalid Masum <khalid.masum.92@xxxxxxxxx> · Mon, 15 Aug 2022 21:53:54 +0600

On 8/15/22 21:17, Dong, Ruijing wrote:
[AMD Official Use Only - General]

If the condition was met and it came to execute vcn_4_0_stop_dpg_mode, then it would never have a chance to go for /*wait for vcn idle*/, isn't it?

Hypothetically, some other thread might set adev->pg_flags NULL and in 
that case it will get the chance to go for /* wait for vcn idle */.

I still didn't see obvious purpose of this change.

                 if (adev->pg_flags & AMD_PG_SUPPORT_VCN_DPG) {
      ==>              r = vcn_v4_0_stop_dpg_mode(adev, i);

Regardless of that, this assignment to r is unnecessary. Because this 
value of r is never used. This patch simply removes this unnecessary
assignment.

                          continue;
                  }

                  /* wait for vcn idle */
                  r = SOC15_WAIT_ON_RREG(VCN, i, regUVD_STATUS, UVD_STATUS__IDLE, 0x7);

Thanks
Ruijing

Thanks,
  -- Khalid Masum