Hi Pekka,
Thanks. If I paraphrase, I think you’re telling me that gbm_bo_get_modifiers() == 0 is not strong enough then.
That fits with the notes on the drm_fourcc.h declaration of the linear format flag:
https://elixir.bootlin.com/linux/latest/source/include/uapi/drm/drm_fourcc.h#L448
Any idea what’s up with some compositors adding code to infer DRM_FORMAT_MOD_LINEAR semantics when the buffer’s modifiers are set to 0? Wlroots, for example, added this as a “safety net for drm drivers not announcing modifiers”.
https://source.puri.sm/Librem5/wlroots/-/merge_requests/63
-Matt
Thanks. If I paraphrase, I think you’re telling me that gbm_bo_get_modifiers() == 0 is not strong enough then.
That fits with the notes on the drm_fourcc.h declaration of the linear format flag:
https://elixir.bootlin.com/linux/latest/source/include/uapi/drm/drm_fourcc.h#L448
Any idea what’s up with some compositors adding code to infer DRM_FORMAT_MOD_LINEAR semantics when the buffer’s modifiers are set to 0? Wlroots, for example, added this as a “safety net for drm drivers not announcing modifiers”.
https://source.puri.sm/Librem5/wlroots/-/merge_requests/63
-Matt
From: Pekka Paalanen <ppaalanen@xxxxxxxxx>
Sent: Saturday, August 6, 2022 6:47:00 AM
To: Hoosier, Matt
Cc: wayland-devel@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx
Subject: Re: How to test whether a buffer is in linear format
Sent: Saturday, August 6, 2022 6:47:00 AM
To: Hoosier, Matt
Cc: wayland-devel@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx
Subject: Re: How to test whether a buffer is in linear format
On Fri, 5 Aug 2022 12:32:01 +0000
"Hoosier, Matt" <Matt.Hoosier@xxxxxxxxxx> wrote:
> Suppose that I want to map a GPU buffer to the CPU and do image
> analysis on it. I know all the usual cautions about this being a
> poor performance option, etc. But suppose for the moment that the
> use-case requires it.
>
> What's the right set of preconditions to conclude that the buffer
> is in vanilla linear representation? In other words: no
> compression, tiling, or any other proprietary GPU tricks that
> would prevent accessing the pixel data in the same way you would
> for a dumb buffer.
>
Hi Matt,
whoever produced the buffer must *explicitly* tell you that the
buffer is using the DRM format modifier DRM_FORMAT_MOD_LINEAR.
> I think that requiring the modifiers to be 0x0 would suffice. But
> is that overkill? Maybe there are situations when some modifiers
> are set, but they don't affect the interpretation of the pixel
> data.
It is not overkill, it is strictly necessary. It is not sufficient
though, you must know things like stride and offset for each plane
as well in addition to width, height and pixel format. All those
together should be enough. Note, that DRM_FORMAT_MOD_LINEAR must be
explicit. If you lack a modifier, you cannot assume it is linear.
No modifier can ever be ignored. If there is no modifier, or it is
invalid, then you must use some originating-driver specific means
to figure out what the "real modifier" is.
Thanks,
pq
"Hoosier, Matt" <Matt.Hoosier@xxxxxxxxxx> wrote:
> Suppose that I want to map a GPU buffer to the CPU and do image
> analysis on it. I know all the usual cautions about this being a
> poor performance option, etc. But suppose for the moment that the
> use-case requires it.
>
> What's the right set of preconditions to conclude that the buffer
> is in vanilla linear representation? In other words: no
> compression, tiling, or any other proprietary GPU tricks that
> would prevent accessing the pixel data in the same way you would
> for a dumb buffer.
>
Hi Matt,
whoever produced the buffer must *explicitly* tell you that the
buffer is using the DRM format modifier DRM_FORMAT_MOD_LINEAR.
> I think that requiring the modifiers to be 0x0 would suffice. But
> is that overkill? Maybe there are situations when some modifiers
> are set, but they don't affect the interpretation of the pixel
> data.
It is not overkill, it is strictly necessary. It is not sufficient
though, you must know things like stride and offset for each plane
as well in addition to width, height and pixel format. All those
together should be enough. Note, that DRM_FORMAT_MOD_LINEAR must be
explicit. If you lack a modifier, you cannot assume it is linear.
No modifier can ever be ignored. If there is no modifier, or it is
invalid, then you must use some originating-driver specific means
to figure out what the "real modifier" is.
Thanks,
pq
CONFIDENTIALITY NOTICE: This email and any attachments are for the sole use of the intended recipient(s) and contain information that may be Garmin confidential and/or Garmin legally privileged. If you have received this email in error, please notify the sender by reply email and delete the message. Any disclosure, copying, distribution or use of this communication (including attachments) by someone other than the intended recipient is prohibited. Thank you.
