[AMD Official Use Only - General] Thanks for the fixes! The series is reviewed-by: Evan Quan <evan.quan@xxxxxxx> Evan > -----Original Message----- > From: Zhen Ni <nizhen@xxxxxxxxxxxxx> > Sent: Wednesday, August 3, 2022 5:20 PM > To: airlied@xxxxxxxx; daniel@xxxxxxxx; Quan, Evan <Evan.Quan@xxxxxxx>; > Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Koenig, Christian > <Christian.Koenig@xxxxxxx>; Pan, Xinhui <Xinhui.Pan@xxxxxxx> > Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; Zhen Ni <nizhen@xxxxxxxxxxxxx> > Subject: [PATCH 2/2] drm/amd/pm: Fix a potential gpu_metrics_table > memory leak > > Memory is allocated for gpu_metrics_table in > smu_v13_0_5_init_smc_tables(), but not freed in > smu_v13_0_5_fini_smc_tables(). This may cause memory leaks, fix it. > > Signed-off-by: Zhen Ni <nizhen@xxxxxxxxxxxxx> > --- > drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c > b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c > index b81711c4ff33..267c9c43a010 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c > @@ -167,6 +167,9 @@ static int smu_v13_0_5_fini_smc_tables(struct > smu_context *smu) > kfree(smu_table->watermarks_table); > smu_table->watermarks_table = NULL; > > + kfree(smu_table->gpu_metrics_table); > + smu_table->gpu_metrics_table = NULL; > + > return 0; > } > > -- > 2.20.1 > >
