Hi Sam, OpenChrome DDX carries lots of legacy code. https://cgit.freedesktop.org/openchrome/xf86-video-openchrome/tree/src/via_drm.h?h=main&id=dc661c59257e855cd9b29c14b91a8ee2d9b86ccb There is a requirement to use the same via_drm.h with both DDX and DRM. Hence, I need to keep a lot of the legacy DRI1 definitions inside via_drm.h. Regards, Kevin Brace Brace Computer Laboratory blog https://bracecomputerlab.com > Sent: Monday, August 01, 2022 at 7:40 AM > From: "Sam Ravnborg" <sam@xxxxxxxxxxxx> > To: "Kevin Brace" <kevinbrace@xxxxxxx> > Cc: "Thomas Zimmermann" <tzimmermann@xxxxxxx>, dri-devel@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH v3 26/32] drm/via: Add via_drm.h > > Hi Kevin, > > > I cannot drop the older DRI1 based uAPI calls. > > This is because include/uapi/drm/via_drm.h needs to retain backward > > compatibility with the existing OpenChrome DDX's XvMC library > > (it gets compiled when OpenChrome DDX is built) and likely with the > > existing DDX Xv code as well. > > If I remove the DRI1 based uAPI calls, the XvMC library will not get > > compiled (compile error will occur since the XvMC library assumes the > > presence of DRI1 based uAPI), and I assume the same for the DDX Xv code > > (I cannot even reach here since the XvMC library is compiled first). > > If you just keep the relevant definitions in drm_via.h then the compile > issues should be OK - and then there is no need to implement anything in > the driver. Or did I not understand the problem you are trying to solve? > > Sam >
