Re: [PATCH v2 02/10] drm/simpledrm: Inline device-init helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

Am 25.07.22 um 17:01 schrieb Javier Martinez Canillas:
Hello Thomas,

On 7/20/22 16:27, Thomas Zimmermann wrote:
Inline the helpers for initializing the hardware FB, the memory
management and the modesetting into the device-creation function.
No functional changes.


Could you please elaborate in the commit message why this change is
desirable?  Without this additional context, this feels like going
backwards, since you are dropping few helpers that have quite self
contained code and making simpledrm_device_create() much larger.

To clarify: I want to make the init code more easy to follow. These old init functions still had to be called in the right order as each possibly depends on settings from the others. It also feels like it's easier to extract common code for ofdrm. And the pipeline is static, so it doesn't require complex chains of helper calls. Having everything in one helper seems beneficial. (It's a trade-off, I know.)

Best regards
Thomas



--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux