Hello Michal,
On 7/26/22 16:40, Michal Suchánek wrote:
> Hello,
>
> On Tue, Jul 26, 2022 at 03:38:37PM +0200, Javier Martinez Canillas wrote:
>> On 7/20/22 16:27, Thomas Zimmermann wrote:
>>> Add a per-model device-function structure in preparation of adding
>>> color-management support. Detection of the individual models has been
>>> taken from fbdev's offb.
>>>
>>> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
>>> ---
>>
>> Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
>>
>> [...]
>>
>>> +static bool is_avivo(__be32 vendor, __be32 device)
>>> +{
>>> + /* This will match most R5xx */
>>> + return (vendor == 0x1002) &&
>>> + ((device >= 0x7100 && device < 0x7800) || (device >= 0x9400));
>>> +}
>>
>> Maybe add some constant macros to not have these magic numbers ?
>
> This is based on the existing fbdev implementation's magic numbers:
>
> drivers/video/fbdev/offb.c: ((*did >= 0x7100 && *did < 0x7800) ||
>
Ah, I see. Then we might have to go with the magic numbers...
> Of course, it would be great if somebody knowledgeable could clarify
> those.
>
Indeed.
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
