Re: [PATCH v2 3/8] drm/vmwgfx: Use the hotspot properties from cursor planes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Martin Krastev <krastevm@xxxxxxxxxx>


On 12.07.22 г. 6:32 ч., Zack Rusin wrote:
From: Zack Rusin <zackr@xxxxxxxxxx>

Atomic modesetting got support for mouse hotspots via the hotspot
properties. Port the legacy kms hotspot handling to the new properties
on cursor planes.

Signed-off-by: Zack Rusin <zackr@xxxxxxxxxx>
Cc: Martin Krastev <krastevm@xxxxxxxxxx>
Cc: Maaz Mombasawala <mombasawalam@xxxxxxxxxx>
---
  drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 9 ++-------
  1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index ff2f735bbe7a..3d3f73109199 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
@@ -652,13 +652,8 @@ vmw_du_cursor_plane_atomic_update(struct drm_plane *plane,
  	struct vmw_plane_state *vps = vmw_plane_state_to_vps(new_state);
  	s32 hotspot_x, hotspot_y;
- hotspot_x = du->hotspot_x;
-	hotspot_y = du->hotspot_y;
-
-	if (new_state->fb) {
-		hotspot_x += new_state->fb->hot_x;
-		hotspot_y += new_state->fb->hot_y;
-	}
+	hotspot_x = du->hotspot_x + new_state->hotspot_x;
+	hotspot_y = du->hotspot_y + new_state->hotspot_y;
du->cursor_surface = vps->surf;
  	du->cursor_bo = vps->bo;


LGTM.
Reviewed-by: Martin Krastev <krastevm@xxxxxxxxxx>

Regards,
Martin



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux