On 22/07/2022 20:32, John Harrison wrote:
On 7/19/2022 02:56, Tvrtko Ursulin wrote:
On 19/07/2022 01:13, John Harrison wrote:
On 7/18/2022 05:35, Tvrtko Ursulin wrote:
On 13/07/2022 00:31, John.C.Harrison@xxxxxxxxx wrote:
From: Matthew Brost <matthew.brost@xxxxxxxxx>
The GuC needs a copy of a golden context for implementing watchdog
resets (aka media resets). This context is larger on newer platforms.
So adjust the size being allocated/copied accordingly.
What were the consequences of this being too small? Media watchdog
reset broken impacting userspace? Platforms? Do we have an IGT
testcase? Do we need a Fixes: tag? Copy stable?
Yes. Not sure if we have an IGT for the media watchdog. I recall
writing something a long time back but I don't think it ever got
merged due to push back that I don't recall right now. And no because
it only affects DG2 onwards which is still forceprobed.
Right, hm, I don't know if the MBD SKU promise for DG2 relies on force
probe removal or not. My impression certainly was that a bunch of uapi
we recently merged made people happy in that respect - that we
satisfied the commit to deliver that support with 5.19. Maybe I am
wrong, or perhaps to err on the side of safety you could add the right
Fixes: tag regardless? Pick some patch which enables GuC for DG2 if
there isn't anything better I guess. Or you could check with James.
Adding "Fixes: random patch that is actually irrelevant" seems like the
wrong thing to do. This is not a bug fix. It is new platform support.
And it is not the only thing required to support that new platform that
is not currently in 5.19. E.g. DG2 requires at least GuC v70.4.2 to
support some hardware w/a's. The guidance for that was to not add Fixes
tags but to send a manual pull request once everything is ready.
All I know is that some people were really interested(*) that 5.19
contains everything needed for DG2. Hence I suggested to err on the side
of safety, or at least check with folks.
Bottom line is, if you want this fix to be in 5.19, or even 5.20, you
should add a Fixes: tag. Otherwise it will be in 5.21 at the earliest.
Your call, I only tried to be helpful and avoid another failure.
Regards,
Tvrtko
*) To the point of actively pining the maintainers to ensure patches do
not miss the merge window.
