On Fri, Jul 22, 2022 at 12:25 PM ChiaEn Wu <peterwu.pub@xxxxxxxxx> wrote: > > From: ChiYuan Huang <cy_huang@xxxxxxxxxxx> > > The MediaTek MT6370 is a highly-integrated smart power management IC, > which includes a single cell Li-Ion/Li-Polymer switching battery > charger, a USB Type-C & Power Delivery (PD) controller, dual > Flash LED current sources, a RGB LED driver, a backlight WLED driver, > a display bias driver and a general LDO for portable devices. > > Add support for the Type-C & Power Delivery controller in > MediaTek MT6370 IC. ... > +static int mt6370_tcpc_set_vconn(struct tcpci *tcpci, struct tcpci_data *data, > + bool enable) > +{ > + return regmap_update_bits(data->regmap, MT6370_REG_SYSCTRL8, > + MT6370_AUTOIDLE_MASK, > + !enable ? MT6370_AUTOIDLE_MASK : 0); Why not positive conditional? enable ? 0 : mask > +} ... > + ret = devm_add_action_or_reset(dev, mt6370_unregister_tcpci_port, > + priv->tcpci); I believe nothing bad will happen if you put it on one line. -- With Best Regards, Andy Shevchenko