On Thu, 21 Jul 2022 at 13:18, Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
>
> On 21/07/2022 11:22, Chen-Yu Tsai wrote:
> > The datasheet says that VDD12 must be enabled and at full voltage before
> > VDD33 is enabled.
> >
> > Reorder the bulk regulator supply names so that VDD12 is enabled before
> > VDD33. Any enable ramp delays should be handled by setting proper
> > constraints on the regulators.
> >
> > Fixes: bc1aee7fc8f0 ("drm/bridge: Add I2C based driver for ps8640 bridge")
> > Signed-off-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>
> > ---
> > drivers/gpu/drm/bridge/parade-ps8640.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
> > index 31e88cb39f8a..49107a6cdac1 100644
> > --- a/drivers/gpu/drm/bridge/parade-ps8640.c
> > +++ b/drivers/gpu/drm/bridge/parade-ps8640.c
> > @@ -631,8 +631,8 @@ static int ps8640_probe(struct i2c_client *client)
> > if (!ps_bridge)
> > return -ENOMEM;
> >
> > - ps_bridge->supplies[0].supply = "vdd33";
> > - ps_bridge->supplies[1].supply = "vdd12";
> > + ps_bridge->supplies[0].supply = "vdd12";
> > + ps_bridge->supplies[1].supply = "vdd33";
> > ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ps_bridge->supplies),
> > ps_bridge->supplies);
> > if (ret)
>
> Reviewed-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
Applied to drm-misc-next.
