Hi Jagan, On 20.07.2022 17:52, Jagan Teki wrote: > Add module init and exit functions for the bridge to register > and unregister dsi_driver. > > Exynos drm driver stack will register the platform_driver separately > in the common of it's exynos_drm_drv.c including dsi_driver. > > Register again would return -EBUSY, so return 0 for such cases as > dsi_driver is already registered. I've already pointed that this is a bad style solution. It will also not work in the following cases: 1. exynos drm and samsung-dsim compiled as modules - samsung-dsim module, once loaded, will register the driver and exynos_drm won't be able to register the exynos_dsi. 2. multi-arch case - if one compiles a kernel (disto-style) with drivers for both supported architectures (exynos and imx) - in such case it will not work on imx, because exynos_drm driver will always register exynos_dsi driver first (even if the kernel is booted on non-exynos board). Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
