Hi Sam Am 20.07.22 um 17:08 schrieb Sam Ravnborg:
Hi Thomas, On Wed, Jul 20, 2022 at 10:30:51AM +0200, Thomas Zimmermann wrote:The plane helpers are included by dozens of files without any need. Only a hand full of source files need anything from drm_plane_helper.h. Untangle everything and tidy up the code a bit. The patches were built on x64-64, aarch64 and arm without issues.Build tested the final result here on a few more archs without any issues. I like the removal of the include statements and the simpler header file.
Thanks for testing. I was surprised that nothing really needed drm_plane_helper.h.
I did not really get what is gained by pushing out drm_plane_funcs to the drivers but trust this is in the end a better solution.
On one hand, I think it's not possible to declare the symbol without including drm_plane.h. So removing it reduces the number of include statements.
In terms of software design, these exported, pre-initialized data structures are like blackboxes and with little flexibility. But DRM helpers should rather be like a construction kit, where drivers can pick individual pieces from.
Series is: Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
Thank you Best regards Thomas
Sam
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
