Hi Sam On Sun, 17 Jul 2022 at 18:58, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > > Add todo in the hope someone will help updating the bridge drivers. > > v2: > - Updated descriptions in todo.rst > > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > Acked-by: Maxime Ripard <mripard@xxxxxxxxxx> > Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> > Cc: Maxime Ripard <mripard@xxxxxxxxxx> > Cc: Thomas Zimmermann <tzimmermann@xxxxxxx> > Cc: David Airlie <airlied@xxxxxxxx> > Cc: Daniel Vetter <daniel@xxxxxxxx> > --- > Documentation/gpu/todo.rst | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index 10bfb50908d1..fbcc232e0bc1 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -480,6 +480,26 @@ Contact: Thomas Zimmermann <tzimmermann@xxxxxxx> > > Level: Starter > > +Drop use of deprecated operations in bridge drivers > +-------------------------------------------------- > + > +&struct drm_bridge_funcs contains a number of deprecated operations > +which can be replaced by the atomic variants. > + > +The following is more or less 1:1 replacements with the arguments > +and names adjusted: > +* pre_enable => atomic_pre_enable > +* enable => atomic_enable > +* disable => atomic_disable > +* post_disable => atomic_post_disable > + > +* mode_set is no longer required and the implementation shall be merged > + with atomic_enable. The dw-mipi-dsi and msm DSI host controller bridge drivers are currently relying on mode_set as a convenient hook to power up the DSI host prior to pre_enable of the bridge chain. Removing it is therefore going to break those. There is a proposed mechanism to allow for the removal of this hack [1], but it's still waiting on R-B tags and/or discussion from bridge maintainers (gentle nudge as you are one of those maintainers). And do you mean merge with atomic_enable, or merge with atomic_pre_enable? atomic_pre_enable would be more applicable for almost all the bridges I'm aware of as they want to be configured before video starts. Cheers, Dave [1] https://lists.freedesktop.org/archives/dri-devel/2022-March/345466.html > +Contact: bridge maintainers, Sam Ravnborg <sam@xxxxxxxxxxxx>, > + Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > + > +Level: Beginner or intermediate (depending on the driver) > > Core refactorings > ================= > -- > 2.34.1 >
