On 7/16/22 20:17, Sam Ravnborg wrote: > drm/dri1 is the new home for all the legacy DRI1 drivers. > > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > Suggested-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> > --- Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> I wonder if we should just squash patches 03/11 to 09/11 into a single patch. Although I guess having them in separate patches makes it easier to get the acks from the drivers' maintainers. [...] > index 73c0aa1c7b94..f639d5e0ae2e 100644 > --- a/drivers/gpu/drm/dri1/Makefile > +++ b/drivers/gpu/drm/dri1/Makefile > @@ -5,6 +5,7 @@ > obj-$(CONFIG_DRM_I810) += i810/ > obj-$(CONFIG_DRM_MGA) += mga/ > obj-$(CONFIG_DRM_R128) += r128/ > +obj-$(CONFIG_DRM_SAVAGE) += savage/ > obj-$(CONFIG_DRM_SIS) += sis/ > obj-$(CONFIG_DRM_TDFX) += tdfx/ > obj-$(CONFIG_DRM_VIA) += via/ Maybe we should call these CONFIG_DRM_DRI1_FOO to make more clear in kernel configs whether DRM or DRI1 drivers are being enabled? After all, the menuconfig now is called DRM_DRI1 and the drivers enabled when CONFIG_DRM_DRI1 is set. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat
