Hello Sam, Thanks a lot for working on this patch-set. On 7/16/22 20:17, Sam Ravnborg wrote: > "legacy" is a general term - be specific and use the term dri1. > The first step is to rename DRIVER_LEGACY to DRIVER_DRI1. > > Suggested-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> IIRC it was Thomas who suggested the s/DRIVER_LEGACY/DRIVER_DRI1 rename, while I suggested the move to a separate dri1 directory. > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > --- Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> [...] > if (!drm_core_check_feature(dev, DRIVER_KMS_LEGACY_CONTEXT) && Not for this series but I wonder when this could be dropped since is only used by nouveau and only when CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT is enabled. AFAIK this is only needed for an old nouveau DDX so I wonder whether someone even still uses that in practice. For example, we don't even set CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT in the Fedora kernel configs. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat
