Re: [PATCH] Revert "drm/amdgpu: add drm buddy support to amdgpu"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 14.07.22 um 15:19 schrieb Mauro Carvalho Chehab:
On Thu, 14 Jul 2022 15:08:48 +0200
Christian König <christian.koenig@xxxxxxx> wrote:

Hi Mauro,

well the last time I checked drm-tip was clean.

The revert is necessary because we had some problems with the commit
which we couldn't fix in the 5.19 cycle.
I see. I don't have any issues with the patch itself, provided that drm-tip
build doesn't break ;-)

I will double check drm-tip once more.
Did a new rebase on the top of:
	bc04f10d22f7 (drm-tip/drm-tip) drm-tip: 2022y-07m-14d-12h-41m-36s UTC integration manifest

I have absolutely no idea what's going wrong here.

After just running "dim rebuild-tip" once more my drm-tip is at:

commit bc04f10d22f7d8a6d76abe431cfb6ef6ba67ad0c (drm-tip/drm-tip, drm-tip)
Author: Christian König <christian.koenig@xxxxxxx>
Date:   Thu Jul 14 14:42:33 2022 +0200

    drm-tip: 2022y-07m-14d-12h-41m-36s UTC integration manifest

And that's compiling perfectly fine.

Regards,
Christian.


And it is still broken on amdgpu_vram_mgr.c, but now with different issues:

drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c: In function ‘amdgpu_vram_mgr_new’:
drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:465:13: error: ‘i’ undeclared (first use in this function)
   465 |         if (i == 1)
       |             ^
drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:465:13: note: each undeclared identifier is reported only once for each function it appears in
drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:466:17: error: ‘node’ undeclared (first use in this function)
   466 |                 node->base.placement |= TTM_PL_FLAG_CONTIGUOUS;
       |                 ^~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:365:33: error: unused variable ‘block’ [-Werror=unused-variable]
   365 |         struct drm_buddy_block *block;
       |                                 ^~~~~
cc1: all warnings being treated as errors

Regards,
Mauro




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux