On Mon, Jul 11, 2022 at 9:23 PM John Stultz <jstultz@xxxxxxxxxx> wrote: > > After having to debug down through the kernel to figure out > why my _WAIT calls were always timing out, I realized its > an absolute timeout value instead of the more common relative > timeouts. > > This detail should be called out in the documentation, as while > the absolute value makes sense here, its not as common for timeout > values. > > Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> > Cc: Maxime Ripard <mripard@xxxxxxxxxx> > Cc: Thomas Zimmermann <tzimmermann@xxxxxxx> > Cc: Jason Ekstrand <jason@xxxxxxxxxxxxxx> > Cc: Christian König <christian.koenig@xxxxxxx> > Cc: Lionel Landwerlin <lionel.g.landwerlin@xxxxxxxxx> > Cc: Chunming Zhou <david1.zhou@xxxxxxx> > Cc: David Airlie <airlied@xxxxxxxx> > Cc: Daniel Vetter <daniel@xxxxxxxx> > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx > Signed-off-by: John Stultz <jstultz@xxxxxxxxxx> > --- > drivers/gpu/drm/drm_syncobj.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c > index 7e48dcd1bee4..b84d842a1c21 100644 > --- a/drivers/gpu/drm/drm_syncobj.c > +++ b/drivers/gpu/drm/drm_syncobj.c > @@ -136,6 +136,10 @@ > * requirement is inherited from the wait-before-signal behavior required by > * the Vulkan timeline semaphore API. > * > + * It should be noted, that both &DRM_IOCTL_SYNCOBJ_WAIT and > + * &DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT takes an *absolute* CLOCK_MONOTONIC Gah. That should be &DRM_IOCTL_SYNCOBJ_TIMELINE_WAIT. I must have pasted in the wrong symbol. Fixed in my tree and I'll share v2 in a few days so I can get additional feedback. thanks -john
