Re: [PATCH libdrm] util: Fix grey in YUV SMPTE patterns

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Thank you for the patch.

On Mon, Jul 11, 2022 at 05:54:46PM +0200, Geert Uytterhoeven wrote:
> The YUV SMPTE patterns use RGB 191/192/192 instead of 192/192/192 for
> the grey color in the top color bar.
> 
> Change it to 192/192/192, to match the RGB SMPTE patterns.
> 
> Fixes: a94ee624292bff96 ("modetest: Add SMPTE test pattern")
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
>  tests/util/pattern.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/util/pattern.c b/tests/util/pattern.c
> index 158c0b160a2ee870..f28fad311ec3de11 100644
> --- a/tests/util/pattern.c
> +++ b/tests/util/pattern.c
> @@ -162,7 +162,7 @@ static void fill_smpte_yuv_planar(const struct util_yuv_info *yuv,
>  				  unsigned int height, unsigned int stride)
>  {
>  	const struct color_yuv colors_top[] = {
> -		MAKE_YUV_601(191, 192, 192),	/* grey */
> +		MAKE_YUV_601(192, 192, 192),	/* grey */
>  		MAKE_YUV_601(192, 192, 0),	/* yellow */
>  		MAKE_YUV_601(0, 192, 192),	/* cyan */
>  		MAKE_YUV_601(0, 192, 0),	/* green */
> @@ -265,7 +265,7 @@ static void fill_smpte_yuv_packed(const struct util_yuv_info *yuv, void *mem,
>  				  unsigned int stride)
>  {
>  	const struct color_yuv colors_top[] = {
> -		MAKE_YUV_601(191, 192, 192),	/* grey */
> +		MAKE_YUV_601(192, 192, 192),	/* grey */
>  		MAKE_YUV_601(192, 192, 0),	/* yellow */
>  		MAKE_YUV_601(0, 192, 192),	/* cyan */
>  		MAKE_YUV_601(0, 192, 0),	/* green */

-- 
Regards,

Laurent Pinchart



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux