Re: [PATCH v5 00/10] Add PSR support for eDP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/07/2022 12:47, Vinod Polimera wrote:
Changes in v2:
   - Use dp bridge to set psr entry/exit instead of dpu_enocder.
   - Don't modify whitespaces.
   - Set self refresh aware from atomic_check.
   - Set self refresh aware only if psr is supported.
   - Provide a stub for msm_dp_display_set_psr.
   - Move dp functions to bridge code.

Changes in v3:
   - Change callback names to reflect atomic interfaces.
   - Move bridge callback change to separate patch as suggested by Dmitry.
   - Remove psr function declaration from msm_drv.h.
   - Set self_refresh_aware flag only if psr is supported.
   - Modify the variable names to simpler form.
   - Define bit fields for PSR settings.
   - Add comments explaining the steps to enter/exit psr.
   - Change DRM_INFO to drm_dbg_db.

Changes in v4:
   - Move the get crtc functions to drm_atomic.
   - Add atomic functions for DP bridge too.
   - Add ternary operator to choose eDP or DP ops.
   - Return true/false instead of 1/0.
   - mode_valid missing in the eDP bridge ops.
   - Move the functions to get crtc into drm_atomic.c.
   - Fix compilation issues.
   - Remove dpu_assign_crtc and get crtc from drm_enc instead of dpu_enc.
   - Check for crtc state enable while reserving resources.

Changes in v5:
   - Move the mode_valid changes into a different patch.
   - Complete psr_op_comp only when isr is set.
   - Move the DP atomic callback changes to a different patch.
   - Get crtc from drm connector state crtc.
   - Move to separate patch for check for crtc state enable while
reserving resources.

Signed-off-by: Sankeerth Billakanti <quic_sbillaka@xxxxxxxxxxx>
Signed-off-by: Kalyan Thota <quic_kalyant@xxxxxxxxxxx>
Signed-off-by: Vinod Polimera <quic_vpolimer@xxxxxxxxxxx>

Vinod Polimera (10):
   drm/msm/disp/dpu1: clear dpu_assign_crtc and get crtc from connector
     state instead of dpu_enc

Generic comment: please use 'drm/msm/dpu:' prefix instead.

   drm: add helper functions to retrieve old and new crtc
   drm/msm/dp: use atomic callbacks for DP bridge ops
   drm/msm/dp: Add basic PSR support for eDP
   drm/msm/dp: use the eDP bridge ops to validate eDP modes
   drm/bridge: use atomic enable/disable callbacks for panel bridge
   drm/bridge: add psr support for panel bridge callbacks
   drm/msm/disp/dpu1: use atomic enable/disable callbacks for encoder
     functions
   drm/msm/disp/dpu1: add PSR support for eDP interface in dpu driver
   drm/msm/disp/dpu1: check for crtc enable rather than crtc active to
     release shared resources

  drivers/gpu/drm/bridge/panel.c              |  68 ++++++++--
  drivers/gpu/drm/drm_atomic.c                |  60 +++++++++
  drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c    |  17 ++-
  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c |  55 +++++---
  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h |   8 --
  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c     |   2 +-
  drivers/gpu/drm/msm/dp/dp_catalog.c         |  81 ++++++++++++
  drivers/gpu/drm/msm/dp/dp_catalog.h         |   4 +
  drivers/gpu/drm/msm/dp/dp_ctrl.c            |  73 +++++++++++
  drivers/gpu/drm/msm/dp/dp_ctrl.h            |   3 +
  drivers/gpu/drm/msm/dp/dp_display.c         |  31 +++--
  drivers/gpu/drm/msm/dp/dp_display.h         |   2 +
  drivers/gpu/drm/msm/dp/dp_drm.c             | 187 ++++++++++++++++++++++++++--
  drivers/gpu/drm/msm/dp/dp_drm.h             |   9 +-
  drivers/gpu/drm/msm/dp/dp_link.c            |  36 ++++++
  drivers/gpu/drm/msm/dp/dp_panel.c           |  22 ++++
  drivers/gpu/drm/msm/dp/dp_panel.h           |   6 +
  drivers/gpu/drm/msm/dp/dp_reg.h             |  27 ++++
  include/drm/drm_atomic.h                    |   7 ++
  19 files changed, 634 insertions(+), 64 deletions(-)



--
With best wishes
Dmitry



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux