Hi Molly, On Sun, Jul 10, 2022 at 02:19:41PM +0800, Molly Sophia wrote: > Hi Sam, > > Thanks for your suggestions. > > Sam Ravnborg <sam@xxxxxxxxxxxx> 于 2022年7月10日周日 上午4:47写道： > > > Hi Molly, > > > > thanks for the quick response to the review comments. > > > > On Sat, Jul 09, 2022 at 10:11:35PM +0800, MollySophia wrote: > > > Add documentation for "novatek,nt35596s" panel. > > > > > > Signed-off-by: MollySophia <mollysophia379@xxxxxxxxx> > > The s-o-b needs your real name - guess the above is a concatenation of > > first name and surname. > > > > The binding included in this patch fails the check: > > $ make DT_CHECKER_FLAGS=-m dt_binding_check > > > > You may need to run: > > $ pip3 install dtschema --upgrade > > > > Or you may have to install some dependencies first. > > The problem is that the patch is missing a "reset-gpios: true" > > > > On top of this I looked at the binding - and the description > > this is copied from is almost identical. > > So another approach would be to extend the existing binding like > > in the following. > > > > And this also gives a good hint that maybe this can be embedded in > > the existing driver - and there is no need for a new driver. > > Could you try to give this a spin and get back on this. > > > > That's reasonable. Actually, this driver was modified from > novatek,nt35596s, with different panel initialization commands, and it > seems easy to be embedded in > the existing driver. However, I wonder what the driver file name would > be...? "panel-novatek-nt35596s-nt36672a.c" or something else? Just keep the current driver name - we cannot embed all the supported HW in one driver name anyway. And then you do not break currents users in case they have hardwired the current driver name. Sam
