On Thu, Jul 7, 2022 at 5:37 AM Javier Martinez Canillas <javierm@xxxxxxxxxx> wrote: > > Hello Ezequiel, > > Thanks a lot for your patch. > > On 7/6/22 20:41, Ezequiel Garcia wrote: > > Fix small typo which causes the mask for the 'precharge1' setting > > to be used with the 'precharge2' value. > > > > Signed-off-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxxxxxxxxx> > > --- > > drivers/gpu/drm/solomon/ssd130x.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c > > index 08394444dd6e..f4886e66ff34 100644 > > --- a/drivers/gpu/drm/solomon/ssd130x.c > > +++ b/drivers/gpu/drm/solomon/ssd130x.c > > @@ -350,7 +350,7 @@ static int ssd130x_init(struct ssd130x_device *ssd130x) > > > > /* Set precharge period in number of ticks from the internal clock */ > > precharge = (SSD130X_SET_PRECHARGE_PERIOD1_SET(ssd130x->prechargep1) | > > - SSD130X_SET_PRECHARGE_PERIOD1_SET(ssd130x->prechargep2)); > > + SSD130X_SET_PRECHARGE_PERIOD2_SET(ssd130x->prechargep2)); > > It's a typo indeed. Nice catch! > > I wonder how did you notice this. Or was it just looking at the code ? > Indeed, I was just reviewing the code while getting a SH1106 display to work. > Acked-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> > > I'll push it to drm-misc (drm-misc-fixes). > Thanks! Ezequiel > -- > Best regards, > > Javier Martinez Canillas > Linux Engineering > Red Hat >
