On 7/8/2022 12:51 PM, Stephen Boyd wrote:
Quoting Abhinav Kumar (2022-07-08 12:38:09)
+ kuogee
On 7/8/2022 12:27 PM, Stephen Boyd wrote:
Yes I see the same address for P1 on sc7280. Maybe it's a typo? Abhinav,
can you confirm?
P1 block does exist on sc7280 and yes its address is same as the address
mentioned in sc7180. So its not a typo.
Thanks!
Yes, we are not programming this today but I would prefer to keep this
as optional.
I did sync up with Kuogee on this change this morning, we will check a
few things internally on the P1 block's usage as to which use-cases we
need to program it for and update here.
The idea behind having this register space listed in the yaml is thats
how the software documents have the blocks listed so dropping P1 block
just because its unused seemed wrong to me. Optional seems more appropriate.
It doesn't sound optional on sc7180 or sc7280. It exists in the
hardware, so we should list the reg property. My understanding of
optional properties is for the case where something could be different
in the hardware design, like an optionally connected pin on a device.
Ack, if thats the purpose of optional, then we should keep it and yes
lets drop this change.
