Re: [PATCH] drm/msm/dpu: Fix for non-visible planes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 7/7/2022 2:20 PM, Rob Clark wrote:
From: Rob Clark <robdclark@xxxxxxxxxxxx>

Fixes `kms_cursor_crc --run-subtest cursor-offscreen`.. when the cursor
moves offscreen the plane becomes non-visible, so we need to skip over
it in crtc atomic test and mixer setup.

Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx>
Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>

Will pick up the fixes tag from Dmitry's r-b.
---
  drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
index 4dd0ce09ca74..4ba000951a90 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
@@ -422,6 +422,9 @@ static void _dpu_crtc_blend_setup_mixer(struct drm_crtc *crtc,
  		if (!state)
  			continue;
+ if (!state->visible)
+			continue;
+
  		pstate = to_dpu_plane_state(state);
  		fb = state->fb;
@@ -1195,6 +1198,9 @@ static int dpu_crtc_atomic_check(struct drm_crtc *crtc,
  		if (cnt >= DPU_STAGE_MAX * 4)
  			continue;
+ if (!pstate->visible)
+			continue;
+
  		pstates[cnt].dpu_pstate = dpu_pstate;
  		pstates[cnt].drm_pstate = pstate;
  		pstates[cnt].stage = pstate->normalized_zpos;



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux