On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> Add in missing clock and clock-names declarations to the 28nm DSI PHY.
> When converting from .txt to .yaml we missed these.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---
> .../bindings/display/msm/dsi-phy-28nm.yaml | 17 +++++++++++++++++
You need to fix all your subject prefixes. It's confusing to see again
clocks being fixed for the DSI bindings.
dt-bindings: msm: dsi-phy-28nm:
and similarly for other cases.
> 1 file changed, 17 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> index 3d8540a06fe22..9ecd513d93661 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> @@ -19,6 +19,21 @@ properties:
> - qcom,dsi-phy-28nm-lp
> - qcom,dsi-phy-28nm-8960
>
> + clocks:
> + minItems: 1
> + maxItems: 2
> +
> + clock-names:
> + items:
> + - const: iface
> + description: AHB clock
Descriptions goes to clocks.
> + - const: iface_clk
> + description: AHB clock
> + - const: ref
> + description: Block reference clock
> + minItems: 1
> + maxItems: 2
Did you test it? Three items vs maxItems:2?
> +
> reg:
> items:
> - description: dsi pll register set
> @@ -36,6 +51,8 @@ properties:
>
> required:
> - compatible
> + - clocks
> + - clock-names
> - reg
> - reg-names
> - vddio-supply
Best regards,
Krzysztof
