> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of > Andrzej Hajda > Sent: Thursday, June 23, 2022 10:08 PM > To: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>; Ville Syrjälä > <ville.syrjala@xxxxxxxxxxxxxxx> > Cc: Hajda, Andrzej <andrzej.hajda@xxxxxxxxx>; intel- > gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; Vivi, Rodrigo > <rodrigo.vivi@xxxxxxxxx> > Subject: [Intel-gfx] [PATCH 1/2] drm/i915/hpd: postpone HPD cancel work > after last user suspension > > i915->hotplug.dig_port_work can be queued from intel_hpd_irq_handler > called by IRQ handler or by intel_hpd_trigger_irq called from dp_mst. > To avoid re-queuing lets cancel HPD work after intel_dp_mst_suspend. > It is not re-queuing! I Would rather put it as, a cleaner approach is to flush the hpd work on suspend. With the above said changes included, you can have Reviewed-by: Arun R Murthy <arun.r.murthy@xxxxxxxxx> Thanks and Regards, Arun R Murthy --------------------