> + js_as_offset = slot * 0x80;
JS_SLOT_STRIDE
> + slot = panfrost_job_get_slot(job);
> + slot = slot ? slot : 0;
`slot = slot ? slot : 0` is a no-op. Delete the line.
> + if (!IS_ERR(page))
> + *bomap++ = cpu_to_le64(page_to_phys(page));
> + else {
> + dev_err(pfdev->dev, "Panfrost Dump: wrong page\n");
> + *bomap++ = ~cpu_to_le64(0);
> + }
> + }
Nit: because you have { braces } around half the if, please add
{ braces } around the other half for consistency.
---
As a general note, I'd appreciate breaking out the panfrost_regs.h
changes into a separate patch, as they are a logically separate clean
up to make room for this patch. Thanks.
