Re: [PATCH v8 04/10] drm/i915/gem: selftest should not attempt mmap of private regions

[Thomas Hellström <thomas.hellstrom@xxxxxxxxxxxxxxx>]

On Tue, 2022-06-21 at 20:00 +0000, Robert Beckett wrote:
> During testing make can_mmap consider whether the region is private.
> 
> Signed-off-by: Robert Beckett <bob.beckett@xxxxxxxxxxxxx>

LGTM.
Reviewed-by: Thomas Hellström <thomas.hellstrom@xxxxxxxxxxxxxxx>


> ---
>  drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
> b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
> index 5bc93a1ce3e3..76181e28c75e 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
> @@ -869,6 +869,9 @@ static bool can_mmap(struct drm_i915_gem_object
> *obj, enum i915_mmap_type type)
>         struct drm_i915_private *i915 = to_i915(obj->base.dev);
>         bool no_map;
>  
> +       if (obj->mm.region && obj->mm.region->private)
> +               return false;
> +
>         if (obj->ops->mmap_offset)
>                 return type == I915_MMAP_TYPE_FIXED;
>         else if (type == I915_MMAP_TYPE_FIXED)