Hi Nicolas, Thanks for your comments. On Tue, 2022-06-14 at 13:46 -0400, Nicolas Dufresne wrote: > Le lundi 13 juin 2022 à 16:10 -0400, Nicolas Dufresne a écrit : > > Le jeudi 12 mai 2022 à 11:46 +0800, Yunfei Dong a écrit : > > > Firstly, add mt8186 compatible and private data, then add > > > document for > > > compatible "mediatek,mt8186-vcodec-dec". For mt8186 is single > > > core > > > architecture, need to add new interface for h264 hardware > > > decoder. > > > > Would be nice to take the habit of sharing fluster score for this > > new HW, I > > would expect no less then what the numbers you'd get from running > > over MT8195 or > > 92, remains nice to demonstrate that this was tested and document > > any oops along > > the way. > > > > > > Patche 1 add mt8186 compatible and private data. > > > Patche 2 add mt8186 compatible document. > > > Patche 3 add h264 single core driver. > > > --- > > > This patch depends on "support for MT8192 decoder"[1] > > > > > > [1] > > > https://patchwork.kernel.org/project/linux-mediatek/cover/20220512021950.29087-1-yunfei.dong@xxxxxxxxxxxx/ > > I forgot earlier, but I suppose this will also depends on an scp.img > firmware ? > If so, any linux-firmware submission to link to ? > Yes, need scp.img to test mt8186. But not all patches are merged now, we are testing the driver, will send scp.img in the middle of july. Best Regards, Yunfei Dong > > > --- > > > changed with v3: > > > - fix __iomem not reasonable, align share memory to dram. > > > changed with v2: > > > - fix sparse and smatch check fail for patch 3 > > > changed with v1: > > > - rebase driver to the latest media_stage. > > > --- > > > Yunfei Dong (3): > > > dt-bindings: media: mediatek: vcodec: Adds decoder dt-bindings > > > for > > > mt8186 > > > media: mediatek: vcodec: Support MT8186 > > > media: mediatek: vcodec: add h264 decoder driver for mt8186 > > > > > > .../media/mediatek,vcodec-subdev-decoder.yaml | 4 +- > > > .../platform/mediatek/vcodec/mtk_vcodec_dec.h | 1 + > > > .../mediatek/vcodec/mtk_vcodec_dec_drv.c | 4 + > > > .../vcodec/mtk_vcodec_dec_stateless.c | 19 ++ > > > .../vcodec/vdec/vdec_h264_req_multi_if.c | 177 > > > +++++++++++++++++- > > > 5 files changed, 203 insertions(+), 2 deletions(-) > > > > >