Reviewed-by: Lyude Paul <lyude@xxxxxxxxxx> Also, you have my permission to push this to drm-misc-next. On Mon, 2022-06-20 at 11:46 +0200, Hans de Goede wrote: > Before this change nouveau's Kconfig section had 2 "select ACPI_VIDEO" > statements: > > select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && INPUT > select ACPI_VIDEO if ACPI && X86 > > Drop the one with the extra conditions, if the conditions for that > one are true then the second statement will always select ACPI_VIDEO > already. > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > --- > drivers/gpu/drm/nouveau/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/Kconfig > b/drivers/gpu/drm/nouveau/Kconfig > index 34760164c271..03d12caf9e26 100644 > --- a/drivers/gpu/drm/nouveau/Kconfig > +++ b/drivers/gpu/drm/nouveau/Kconfig > @@ -11,7 +11,6 @@ config DRM_NOUVEAU > select DRM_TTM > select DRM_TTM_HELPER > select BACKLIGHT_CLASS_DEVICE if DRM_NOUVEAU_BACKLIGHT > - select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && INPUT > select X86_PLATFORM_DEVICES if ACPI && X86 > select ACPI_WMI if ACPI && X86 > select MXM_WMI if ACPI && X86 -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat