The drm_buddy is just a software allocator, so don't need to create a module for this small part. If drm_buddy is included in drm module, then only need to insmod drm.ko Signed-off-by: Cai Huoqing <cai.huoqing@xxxxxxxxx> --- drivers/gpu/drm/Kconfig | 2 +- drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_buddy.c | 7 ++----- drivers/gpu/drm/drm_drv.c | 10 ++++++++++ include/drm/drm_buddy.h | 3 +++ 5 files changed, 17 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 22e7fa48d693..6c18b34f25d3 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -180,7 +180,7 @@ config DRM_TTM uses it. config DRM_BUDDY - tristate + bool depends on DRM help A page based buddy allocator diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 13ef240b3d2b..75737ccb5fc0 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -29,6 +29,7 @@ drm-$(CONFIG_PCI) += drm_pci.o drm-$(CONFIG_DEBUG_FS) += drm_debugfs.o drm_debugfs_crc.o drm-$(CONFIG_DRM_LOAD_EDID_FIRMWARE) += drm_edid_load.o drm-$(CONFIG_DRM_PRIVACY_SCREEN) += drm_privacy_screen.o drm_privacy_screen_x86.o +drm-$(CONFIG_DRM_BUDDY) += drm_buddy.o obj-$(CONFIG_DRM) += drm.o obj-$(CONFIG_DRM_NOMODESET) += drm_nomodeset.o diff --git a/drivers/gpu/drm/drm_buddy.c b/drivers/gpu/drm/drm_buddy.c index 11bb59399471..9262811b39ac 100644 --- a/drivers/gpu/drm/drm_buddy.c +++ b/drivers/gpu/drm/drm_buddy.c @@ -767,12 +767,12 @@ void drm_buddy_print(struct drm_buddy *mm, struct drm_printer *p) } EXPORT_SYMBOL(drm_buddy_print); -static void drm_buddy_module_exit(void) +void drm_buddy_slb_blk_put(void) { kmem_cache_destroy(slab_blocks); } -static int __init drm_buddy_module_init(void) +int __init drm_buddy_slb_blk_get(void) { slab_blocks = KMEM_CACHE(drm_buddy_block, 0); if (!slab_blocks) @@ -781,8 +781,5 @@ static int __init drm_buddy_module_init(void) return 0; } -module_init(drm_buddy_module_init); -module_exit(drm_buddy_module_exit); - MODULE_DESCRIPTION("DRM Buddy Allocator"); MODULE_LICENSE("Dual MIT/GPL"); diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 8214a0b1ab7f..2b5d6a8b5572 100644 --- a/drivers/gpu/drm/drm_drv.c +++ b/drivers/gpu/drm/drm_drv.c @@ -44,6 +44,7 @@ #include <drm/drm_mode_object.h> #include <drm/drm_print.h> #include <drm/drm_privacy_screen_machine.h> +#include <drm/drm_buddy.h> #include "drm_crtc_internal.h" #include "drm_internal.h" @@ -1034,6 +1035,9 @@ static const struct file_operations drm_stub_fops = { static void drm_core_exit(void) { drm_privacy_screen_lookup_exit(); +#if IS_ENABLED(CONFIG_DRM_BUDDY) + drm_buddy_slb_blk_put(); +#endif unregister_chrdev(DRM_MAJOR, "drm"); debugfs_remove(drm_debugfs_root); drm_sysfs_destroy(); @@ -1061,6 +1065,12 @@ static int __init drm_core_init(void) if (ret < 0) goto error; +#if IS_ENABLED(CONFIG_DRM_BUDDY) + ret = drm_buddy_slb_blk_get(); + if (!ret) + goto error; +#endif + drm_privacy_screen_lookup_init(); drm_core_init_complete = true; diff --git a/include/drm/drm_buddy.h b/include/drm/drm_buddy.h index 572077ff8ae7..6f648175243c 100644 --- a/include/drm/drm_buddy.h +++ b/include/drm/drm_buddy.h @@ -156,4 +156,7 @@ void drm_buddy_block_print(struct drm_buddy *mm, struct drm_buddy_block *block, struct drm_printer *p); +int __init drm_buddy_slb_blk_get(void); +void drm_buddy_slb_blk_put(void); + #endif -- 2.25.1