> -----Original Message-----
> From: Linux-mediatek <linux-mediatek-bounces@xxxxxxxxxxxxxxxxxxx> On
> Behalf Of CK Hu
> Sent: Friday, June 17, 2022 1:31 PM
> To: Fabien Parent <fparent@xxxxxxxxxxxx>; matthias.bgg@xxxxxxxxx;
> Jitao Shi (石记涛) <jitao.shi@xxxxxxxxxxxx>;
> krzysztof.kozlowski+dt@xxxxxxxxxx; robh+dt@xxxxxxxxxx
> Cc: chunkuang.hu@xxxxxxxxxx; p.zabel@xxxxxxxxxxxxxx; airlied@xxxxxxxx
> ; daniel@xxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx;
> linux-mediatek@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/7] dt-bindings: display: mediatek: dpi: add
> power-domains property
>
> Hi, Fabien:
>
> On Mon, 2022-05-30 at 22:14 +0200, Fabien Parent wrote:
> > DPI is part of the display / multimedia block in MediaTek SoCs,
> > and
> > always have a power-domain (at least in the upstream device-trees).
> > Add the power-domains property to the binding documentation.
> >
> > Signed-off-by: Fabien Parent <fparent@xxxxxxxxxxxx>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 6
> > ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > index 77ee1b923991..caf4c88708f4 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > @@ -57,6 +57,9 @@ properties:
> > Output port node. This port should be connected to the
> > input
> > port of an
> > attached HDMI or LVDS encoder chip.
> >
> > + power-domains:
> > + maxItems: 1
> > +
> > required:
> > - compatible
> > - reg
> > @@ -64,6 +67,7 @@ required:
> > - clocks
> > - clock-names
> > - port
> > + - power-domains
> >
> > additionalProperties: false
> >
> > @@ -71,11 +75,13 @@ examples:
> > - |
> > #include <dt-bindings/interrupt-controller/arm-gic.h>
> > #include <dt-bindings/clock/mt8173-clk.h>
> > + #include <dt-bindings/power/mt8183-power.h>
>
> Why do you include mt8183 power header file for mt8173 dpi node?
>
> Regards,
> CK
>
> >
> > dpi0: dpi@1401d000 {
> > compatible = "mediatek,mt8173-dpi";
> > reg = <0x1401d000 0x1000>;
> > interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>;
> > + power-domains = <&spm MT8173_POWER_DOMAIN_MM>;
> > clocks = <&mmsys CLK_MM_DPI_PIXEL>,
> > <&mmsys CLK_MM_DPI_ENGINE>,
> > <&apmixedsys CLK_APMIXED_TVDPLL>;
>
>
Hi fparent:
I think CK's suggestion, probably because you included the wrong header
file for power.
Because I did not find the definition of MT8173_POWER_DOMAIN_MM in the
path of dt-bindings/power/mt8183-power.h, it was defined in dt-
bindings/power/mt8173-power.h.
Please discuss if you have different opinions.
Best Regards!
xinlei
