On 20/06/2022 09:02, Geert Uytterhoeven wrote:
> Hi Conor,
>
> On Sat, Jun 18, 2022 at 2:32 PM Conor Dooley <mail@xxxxxxxxxxx> wrote:
>> From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>>
>> snps,dwc-ssi-1.01a has a single user - the Canaan k210, which uses a
>> width of 4 for spi-{r,t}x-bus-width. Update the binding to reflect
>> this.
>>
>> Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>
> Thanks for your patch!
>
>> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
>> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
>> @@ -135,19 +135,41 @@ properties:
>> of the designware controller, and the upper limit is also subject to
>> controller configuration.
>>
>> -patternProperties:
>> - "^.*@[0-9a-f]+$":
>> - type: object
>> - properties:
>> - reg:
>> - minimum: 0
>> - maximum: 3
>> -
>> - spi-rx-bus-width:
>> - const: 1
>> -
>> - spi-tx-bus-width:
>> - const: 1
>> +if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: snps,dwc-ssi-1.01a
>> +
>> +then:
>> + patternProperties:
>> + "^.*@[0-9a-f]+$":
>> + type: object
>> + properties:
>> + reg:
>> + minimum: 0
>> + maximum: 3
>> +
>> + spi-rx-bus-width:
>> + const: 4
>> +
>> + spi-tx-bus-width:
>> + const: 4
>
> These two also depend on the board (SPI device + wiring).
> So all of [1, 2, 4] are valid values.
Yeah, I wasn't sure about this one as I was writing it.
enum: [1, 2, 4] I guess.
As always, thanks Geert!
Conor.
>
>> +
>> +else:
>> + patternProperties:
>> + "^.*@[0-9a-f]+$":
>> + type: object
>> + properties:
>> + reg:
>> + minimum: 0
>> + maximum: 3
>> +
>> + spi-rx-bus-width:
>> + const: 1
>> +
>> + spi-tx-bus-width:
>> + const: 1
>>
>> unevaluatedProperties: false
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
