On Tue, 2022-06-14 at 14:24 +0800, CK Hu wrote: > Hi, Bo-Chen: > > On Mon, 2022-06-13 at 14:48 +0800, Bo-Chen Chen wrote: > > From: Guillaume Ranquet <granquet@xxxxxxxxxxxx> > > > > Enabling the dpi too early causes glitches on screen. > > > > Move the call to mtk_dpi_enable() at the end of the bridge_enable > > callback to ensure everything is setup properly before enabling > > dpi. > > This seems a bug fix, so add Fixes tag on this patch. > > Regards, > CK > ok, I will do this using this patch: f89c696e7f635487481eee0d196ab49730ce8664 > > > > Signed-off-by: Guillaume Ranquet <granquet@xxxxxxxxxxxx> > > Signed-off-by: Bo-Chen Chen <rex-bc.chen@xxxxxxxxxxxx> > > --- > > drivers/gpu/drm/mediatek/mtk_dpi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c > > b/drivers/gpu/drm/mediatek/mtk_dpi.c > > index 08c8f21b4421..9668bd5dd14a 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > > @@ -480,7 +480,6 @@ static int mtk_dpi_power_on(struct mtk_dpi > > *dpi) > > if (dpi->pinctrl && dpi->pins_dpi) > > pinctrl_select_state(dpi->pinctrl, dpi->pins_dpi); > > > > - mtk_dpi_enable(dpi); > > return 0; > > > > err_pixel: > > @@ -726,6 +725,7 @@ static void mtk_dpi_bridge_enable(struct > > drm_bridge *bridge) > > > > mtk_dpi_power_on(dpi); > > mtk_dpi_set_display_mode(dpi, &dpi->mode); > > + mtk_dpi_enable(dpi); > > } > > > > static enum drm_mode_status > >
