Hi Ville, On Mon, Jun 13, 2022 at 11:03:10PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > drm_crtc.h has no need for drm_edid.h, so don't include it. > Avoids useless rebuilds of the entire universe when > touching drm_edid.h. > > Quite a few placs do currently depend on drm_edid.h without > actually including it directly. All of those need to be fixed > up. This is a very nice reduction in implicit includes. > > diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_mw.c > index 204c869d9fe2..43de2ac8f27e 100644 > --- a/drivers/gpu/drm/arm/malidp_mw.c > +++ b/drivers/gpu/drm/arm/malidp_mw.c > @@ -10,6 +10,7 @@ > #include <drm/drm_atomic_helper.h> > #include <drm/drm_crtc.h> > #include <drm/drm_fb_cma_helper.h> > +#include <drm/drm_edid.h> > #include <drm/drm_fourcc.h> Please maintain the alphabetic order of the includes. This reduces the risk of conflict when we have multiple edits in different parallel commits. > diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c > index 14a058a42854..4f2fd69c4a4e 100644 > --- a/drivers/gpu/drm/imx/imx-ldb.c > +++ b/drivers/gpu/drm/imx/imx-ldb.c > @@ -22,6 +22,7 @@ > #include <drm/drm_atomic_helper.h> > #include <drm/drm_bridge.h> > #include <drm/drm_fb_helper.h> > +#include <drm/drm_edid.h> ditto > #include <drm/drm_managed.h> > #include <drm/drm_of.h> > #include <drm/drm_panel.h> > diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c > index 2b1fdf2cbbce..9a2fa352a433 100644 > --- a/drivers/gpu/drm/imx/imx-tve.c > +++ b/drivers/gpu/drm/imx/imx-tve.c > @@ -19,6 +19,7 @@ > > #include <drm/drm_atomic_helper.h> > #include <drm/drm_fb_helper.h> > +#include <drm/drm_edid.h> ditto > #include <drm/drm_managed.h> > #include <drm/drm_probe_helper.h> > #include <drm/drm_simple_kms_helper.h> > diff --git a/drivers/gpu/drm/imx/parallel-display.c b/drivers/gpu/drm/imx/parallel-display.c > index 63ba2ad84679..5a91a5c82057 100644 > --- a/drivers/gpu/drm/imx/parallel-display.c > +++ b/drivers/gpu/drm/imx/parallel-display.c > @@ -15,6 +15,7 @@ > #include <drm/drm_atomic_helper.h> > #include <drm/drm_bridge.h> > #include <drm/drm_fb_helper.h> > +#include <drm/drm_edid.h> ditto > #include <drm/drm_managed.h> > #include <drm/drm_of.h> > #include <drm/drm_panel.h> > diff --git a/drivers/gpu/drm/vboxvideo/vbox_mode.c b/drivers/gpu/drm/vboxvideo/vbox_mode.c > index 4017b0a621fc..52eaa10712ec 100644 > --- a/drivers/gpu/drm/vboxvideo/vbox_mode.c > +++ b/drivers/gpu/drm/vboxvideo/vbox_mode.c > @@ -16,6 +16,7 @@ > #include <drm/drm_atomic.h> > #include <drm/drm_atomic_helper.h> > #include <drm/drm_fb_helper.h> > +#include <drm/drm_edid.h> ditto > #include <drm/drm_fourcc.h> > #include <drm/drm_gem_atomic_helper.h> > #include <drm/drm_gem_framebuffer_helper.h> With the above fixed: Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
