Re: [PATCH v7 0/8] Add a panel API to set orientation properly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 9, 2022 at 3:27 PM Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> wrote:
>
> Panels usually call drm_connector_set_panel_orientation(), which is
> later than drm/kms driver calling drm_dev_register(). This leads to a
> WARN()[1].
>
> The orientation property is known earlier. For example, some panels
> parse the property through device tree during probe.
>
> The series add a panel API drm_connector_set_orientation_from_panel()
> for drm/kms drivers. The drivers can call the API to set panel's
> orientation before drm_dev_register().
>
> Panel needs to implement .get_orientation callback to return the property.
>
> [1] https://patchwork.kernel.org/project/linux-mediatek/patch/20220530081910.3947168-2-hsinyi@xxxxxxxxxxxx/
>
> Hsin-Yi Wang (8):
>   drm/panel: Add an API to allow drm to set orientation from panel
>   drm/panel: boe-tv101wum-nl6: Implement .get_orientation callback
>   drm/panel: panel-edp: Implement .get_orientation callback
>   drm/panel: lvds: Implement .get_orientation callback
>   drm/panel: panel-simple: Implement .get_orientation callback
>   drm/panel: ili9881c: Implement .get_orientation callback
>   drm/panel: elida-kd35t133: Implement .get_orientation callback
>   drm: Config orientation property if panel provides it
>
hi Maintainers,

All the patches are reviewed. If there's no other comments, will this
series be picked? Thanks.

>  drivers/gpu/drm/bridge/panel.c                | 34 +++++++++++++++++++
>  drivers/gpu/drm/drm_bridge_connector.c        |  8 ++++-
>  drivers/gpu/drm/drm_connector.c               | 31 +++++++++++++++++
>  .../gpu/drm/panel/panel-boe-tv101wum-nl6.c    | 12 +++++++
>  drivers/gpu/drm/panel/panel-edp.c             | 13 ++++++-
>  drivers/gpu/drm/panel/panel-elida-kd35t133.c  | 12 +++++++
>  drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 12 +++++++
>  drivers/gpu/drm/panel/panel-lvds.c            | 13 +++++++
>  drivers/gpu/drm/panel/panel-simple.c          | 14 +++++++-
>  include/drm/drm_bridge.h                      | 14 ++++++++
>  include/drm/drm_connector.h                   |  4 +++
>  include/drm/drm_panel.h                       |  9 +++++
>  12 files changed, 173 insertions(+), 3 deletions(-)
>
> --
> 2.36.1.255.ge46751e96f-goog
>



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux