Re: [PATCH] drm/mgag200: Include <linux/vmalloc.h> for G200 BIOS code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 08, 2022 at 01:51:22PM +0200, Thomas Zimmermann wrote:
> After moving the vmalloc() call to another file, the rsp include
> statement needs to be moved as well. Resolves a build warning on
> parisc.
> 
>  drivers/gpu/drm/mgag200/mgag200_g200.c: In function
> 	'mgag200_g200_init_refclk':
>  drivers/gpu/drm/mgag200/mgag200_g200.c:120:16: error: implicit
> 	declaration of function 'vmalloc'; did you mean 'kvmalloc'?
> 	[-Werror=implicit-function-declaration]
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Fixes: 85397f6bc4ff ("drm/mgag200: Initialize each model in separate function")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Cc: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Cc: Jocelyn Falempe <jfalempe@xxxxxxxxxx>
> Cc: Dave Airlie <airlied@xxxxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Link: https://lore.kernel.org/all/202206080734.ztAvDG7O-lkp@xxxxxxxxx/

Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
> ---
>  drivers/gpu/drm/mgag200/mgag200_drv.c  | 1 -
>  drivers/gpu/drm/mgag200/mgag200_g200.c | 1 +
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
> index 361eb7dffda1..73e8e4e9e54b 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
> @@ -8,7 +8,6 @@
>  
>  #include <linux/module.h>
>  #include <linux/pci.h>
> -#include <linux/vmalloc.h>
>  
>  #include <drm/drm_aperture.h>
>  #include <drm/drm_drv.h>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_g200.c b/drivers/gpu/drm/mgag200/mgag200_g200.c
> index 616e11391e02..674385921b7f 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_g200.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_g200.c
> @@ -1,6 +1,7 @@
>  // SPDX-License-Identifier: GPL-2.0-only
>  
>  #include <linux/pci.h>
> +#include <linux/vmalloc.h>
>  
>  #include <drm/drm_drv.h>
>  
> -- 
> 2.36.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux