Re: [PATCH] drm/i915/guc: Use drm_err instead of pr_err

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 07 Jun 2022 15:23:17 -0700, John Harrison wrote:
>
> On 6/7/2022 15:07, Dixit, Ashutosh wrote:
> > On Tue, 07 Jun 2022 14:51:03 -0700, John.C.Harrison@xxxxxxxxx wrote:
> >> From: John Harrison <John.C.Harrison@xxxxxxxxx>
> >>
> >> Don't use pr_err in places where we have access to a struct_drm.
> > Seem to be many more pr_err's in selftests. Is there a reason why drm_err's
> > cannot be used in selftests (especially those using an i915 device)?
> > Thanks.
> I figured I'd start small and just do the gt/uc ones to being with as those
> are the ones that affect me.
>
> It sounds like the only reason to use pr_err is in the mock selftests where
> there is no easy access to a DRM structure. For everything else, there is
> no reason that I am aware of.

Fair enough:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@xxxxxxxxx>



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux