On 07.06.2022 08:47, Matt Roper wrote:
> When converting our DSS masks to bitmaps, we fumbled the condition used
> to check whether any DSS are present in the first gslice. Since
> intel_sseu_find_first_xehp_dss() returns a 0-based number, we need a >=
> condition rather than >.
>
> Fixes: b87d39019651 ("drm/i915/sseu: Disassociate internal subslice mask representation from uapi")
> Reported-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@xxxxxxxxx>
> Signed-off-by: Matt Roper <matthew.d.roper@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index 1b191b234160..67104ba8951e 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -2079,7 +2079,7 @@ engine_fake_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
>
> static bool needs_wa_1308578152(struct intel_engine_cs *engine)
> {
> - return intel_sseu_find_first_xehp_dss(&engine->gt->info.sseu, 0, 0) >
> + return intel_sseu_find_first_xehp_dss(&engine->gt->info.sseu, 0, 0) >=
> GEN_DSS_PER_GSLICE;
> }
Acked-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@xxxxxxxxx>
>
> --
> 2.35.3
>
