On Tue, Jun 7, 2022 at 10:13 AM Thomas Zimmermann <tzimmermann@xxxxxxx> wrote: > > Hi > > Am 02.06.22 um 09:24 schrieb Patrik Jakobsson: > > On Tue, May 31, 2022 at 1:15 PM Thomas Zimmermann <tzimmermann@xxxxxxx> wrote: > >> > >> Read the display modes from the connectors DDC helper, which also > >> updates the connector's EDID property. The code for the connector's > >> .get_modes helper is now shared between VGA and SIL164. > >> > >> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > >> --- > >> drivers/gpu/drm/ast/ast_mode.c | 57 ++-------------------------------- > >> 1 file changed, 2 insertions(+), 55 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c > >> index e19dd2f9b3ce..4ff8ec1c8931 100644 > >> --- a/drivers/gpu/drm/ast/ast_mode.c > >> +++ b/drivers/gpu/drm/ast/ast_mode.c > >> @@ -1302,37 +1302,19 @@ static int ast_crtc_init(struct drm_device *dev) > >> > >> static int ast_vga_connector_helper_get_modes(struct drm_connector *connector) > > > > Since this function is now generic you could consider removing _vga > > from the name. > > It's not fully generic. There are DisplayPort functions that do their > own thing. > > From how I understand the driver's source code, there's a hardware > setting to switch between either analog VGA or SIL164-based DVI. Both > use the same registers. So the get_modes function can be shared. What I meant is that there's no VGA specific code left so you could just name it ast_connector_helper_get_modes() But feel free to name it as you like. > > Best regards > Thomas
